feat: add World Heritage Basics navigation to criteria pages#402
Merged
Conversation
Links to all 10 UNESCO selection criteria pages in a 2-column grid, giving users an entry point to /heritages/criteria/:code that didn't previously exist anywhere in the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/heritages/criteria/:codepages had no entry point anywhere in the app (CriteriaTagsitself was unused before that PR)./heritagestop page with links to all 10 UNESCO selection criteria pages, laid out in a 2-column grid with a fixed-width code column so titles align vertically regardless of length.Changes
feat(i18n): addworldHeritageBasics/worldHeritageBasicsDescriptionui-text keysfeat(top): addWorldHeritageBasicscomponent + testfeat(top): renderWorldHeritageBasicsonTopPageTest plan
tsc --noEmitpassesjest— 18 suites / 96 tests passing (2 new tests forWorldHeritageBasics)/heritagesand confirm the section renders with balanced 2-column alignment, and that each link navigates to/heritages/criteria/:code